fix: sequential nano contract register fails on second one #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
approved these changes
Feb 20, 2025
| @@ -91,10 +91,10 @@ export const NewNanoContractTransactionRequest = ({ ncTxRequest }) => { | |||
| * transaction. | |||
| */ | |||
| const [ncAddress, setNcAddress] = useState(registeredNc?.address || firstAddress.address); | |||
| const ncToAccept = useMemo(() => ({ | |||
| const ncToAccept = { | |||
There was a problem hiding this comment.
Since ncToAccept is nested, removing useMemo could indeed negatively affect performance due to unnecessary re-renders and object re-creations, especially if passed as a prop or dependency to components or hooks.
Below is a suggestion, have you tried it?
const ncToAccept = useMemo(() => ({ ...nc, caller: ncAddress, }), [nc, ncAddress]);
Did you face any specific issue with useMemo that led you to remove it?
There was a problem hiding this comment.
Refactored it to still use useMemo and passed ncAddress as a dependency, thanks!
raul-oliveira
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a send nano contract success, if you stay in the success screen and attempt to register a new nano contract, the register will fail until the app is restarted.
Acceptance Criteria
Security Checklist