feat: rpc lib integration #500

andreabadesso · 2024-06-24T16:43:42Z

Screen.Recording.2024-07-12.at.10.07.00.mov

Acceptance Criteria

We should enable wallet-connect
We shouldn't initialize wallet-connect if the wallet-service is enabled
We should be able to handle the htr_signMessageWithAddress and htr_sendNanoContractTx requests
We should display modals for user confirmation and send the response back to wallet connect
We should crash the entire rootSaga if an error happens in a child saga

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

andreabadesso · 2024-07-03T14:15:34Z

shim.js

+const { TextEncoder, TextDecoder } = require('text-encoding');
+
+global.TextDecoder = TextDecoder;
+global.TextEncoder = TextEncoder;
+
+if (typeof btoa === 'undefined') {
+  global.btoa = function (str) {
+    return Buffer.from(str, 'binary').toString('base64');
+  };
+}
+
+if (typeof atob === 'undefined') {
+  global.atob = function (b64Encoded) {
+    return Buffer.from(b64Encoded, 'base64').toString('binary');
+  };
+}


These are needed by wallet-connect

andreabadesso · 2024-07-03T14:15:59Z

src/App.js

@@ -733,8 +736,8 @@ const App = () => (
        >
          <NetworkStatusBar />
          <RootStack />
+          <WalletConnectModal />


So we're able to navigate from inside a modal

src/reducers/reducer.init.js

src/sagas/index.js

andreabadesso · 2024-07-03T16:20:59Z

src/components/WalletConnect/NanoContract/NewNanoContractTransactionModal.js

      />
    </ModalBase>
  );
 };

-const WarnDisclaimer = ({ onReadMore }) => (


Sent to components/WalletConnect/WarnDisclaimer to be reused in other modals

andreabadesso · 2024-07-12T12:03:36Z

src/components/WalletConnect/NanoContract/NewNanoContractTransactionModal.js

+  const onModalDismiss = useCallback(() => {
+    dispatch(walletConnectReject());
+    onDismiss();
+  }, [onDismiss]);


onDismiss comes as a prop, so its reference might change, so we need to pass it as a dep

andreabadesso · 2024-07-12T12:05:48Z

src/components/WalletConnect/NanoContract/NewNanoContractTransactionModal.js

+  useEffect(() => {
+    if (isRetrying) {
+      navigatesToNewNanoContractScreen();
+    }
+  }, [isRetrying, navigation]);


The idea here is to bypass the initial modal when the user is retrying

Without this "redirect", the user would have to press review in this screen again, after pressing "retry":

andreabadesso · 2024-07-12T12:48:28Z

src/screens/PinScreen.js

+      if (this.props.route.params.dispatchResponse) {
+        pinScreenResult(pin);
+      }


I could have passed a callback in the route params, but I don't think that's ideal as it yields a warning, I created this new param dispatchResponse as a new mechanism for getting the result in the sagas

We should refactor this in a future PR to stop passing callbacks as params

locale/pt-br/texts.po

package.json

src/components/WalletConnect/NanoContract/NewNanoContractTransactionModal.js

src/reducers/reducer.init.js

src/sagas/index.js

src/sagas/walletConnect.js

alexruzenhack

We discussed the error handling on saga initialization and I'm letting at your discretion to create or not a simple implementation to halt a saga restart, or defer it to another PR.

andreabadesso requested a review from pedroferreira1 as a code owner June 24, 2024 16:43

andreabadesso self-assigned this Jun 24, 2024

andreabadesso added the enhancement New feature or request label Jun 24, 2024

andreabadesso changed the base branch from master to feat/nano-contract-wallet-connect June 24, 2024 16:44

andreabadesso force-pushed the feat/rpc-lib-integration branch 2 times, most recently from c9a1cbc to 66e00e8 Compare June 24, 2024 16:58

andreabadesso force-pushed the feat/rpc-lib-integration branch from ad99944 to 80cf799 Compare July 3, 2024 14:10

andreabadesso commented Jul 3, 2024

View reviewed changes

src/reducers/reducer.init.js Outdated Show resolved Hide resolved

andreabadesso commented Jul 3, 2024

View reviewed changes

src/sagas/index.js Show resolved Hide resolved

alexruzenhack force-pushed the feat/nano-contract-wallet-connect branch from b2345e7 to d79397b Compare July 3, 2024 14:51

andreabadesso force-pushed the feat/rpc-lib-integration branch from 4947320 to 57ce051 Compare July 3, 2024 16:18

andreabadesso commented Jul 3, 2024

View reviewed changes

andreabadesso force-pushed the feat/rpc-lib-integration branch 2 times, most recently from 006fdbc to 3a16155 Compare July 11, 2024 12:38

alexruzenhack force-pushed the feat/nano-contract-wallet-connect branch from b236a6f to 3af6727 Compare July 11, 2024 14:39

andreabadesso commented Jul 12, 2024

View reviewed changes

andreabadesso requested a review from alexruzenhack July 12, 2024 12:48

andreabadesso force-pushed the feat/rpc-lib-integration branch from 5208d8f to 6a33a5f Compare July 12, 2024 12:59

alexruzenhack force-pushed the feat/nano-contract-wallet-connect branch from 9ef9a80 to a35a521 Compare July 16, 2024 22:17

alexruzenhack reviewed Jul 17, 2024

View reviewed changes

locale/pt-br/texts.po Outdated Show resolved Hide resolved

alexruzenhack reviewed Jul 17, 2024

View reviewed changes

locale/pt-br/texts.po Outdated Show resolved Hide resolved

alexruzenhack reviewed Jul 17, 2024

View reviewed changes

locale/pt-br/texts.po Outdated Show resolved Hide resolved

alexruzenhack suggested changes Jul 17, 2024

View reviewed changes

alexruzenhack force-pushed the feat/rpc-lib-integration branch from 72be982 to 56059a2 Compare July 18, 2024 14:48

alexruzenhack approved these changes Jul 18, 2024

View reviewed changes

alexruzenhack approved these changes Aug 2, 2024

View reviewed changes

andreabadesso added 24 commits August 31, 2024 18:08

chore: changed CI version to 18x and 20x

6cfccf5

chore: updated enable walletconnect script

25f2de8

refactor: removed error logging on NanoContractMethodArgs

0fde00c

chore: removed local library from package-lock.json

a3b1e23

refactor: removed unused option on PinScreen

d116326

fix: added missing import

e083f61

chore: removed comment on pt-br texts

fede251

chore: updated enable-walletconnect.patch

26f761a

refactor: added missing attribute from metadata

4b4486a

chore: updated package-lock with wallet-lib version

0c0eb69

chore: updated locale

2bd638e

chore: restored package-lock.json

7b17750

refactor: NanoContact -> NanoContract

c426b6f

refactor: removed baseStyles prop from WalletConnectModal

468c5d5

refactor: removed package.json changes in walletconnect diff

cf96b79

refactor: reseting nano contract state on unmount

d497129

refactor: acceptedNc -> acceptedReq

6023375

refactor: onReadMore is now on warn component

74c60a4

refactor: .. -> .

d6e0e10

refactor: removed unused styles from NewNanoContractTransctionModal

c9b4495

chore: fix inconsistent return

8feae30

refactor: added missing translations

3a50028

chore: removed .mo

790f87c

refactor: updated patch to remove duplicated shim and podfile.lock

2a6ebf7

andreabadesso force-pushed the feat/rpc-lib-integration branch from b23f09c to 2a6ebf7 Compare August 31, 2024 21:09

pedroferreira1 approved these changes Sep 3, 2024

View reviewed changes

andreabadesso merged commit c306c25 into master Sep 3, 2024
1 check passed

andreabadesso deleted the feat/rpc-lib-integration branch September 3, 2024 16:01

alexruzenhack mentioned this pull request Oct 3, 2024

release-candidate v0.28.0-rc.1 #576

Merged

tuliomir mentioned this pull request Oct 31, 2024

release: v0.28.0 #591

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rpc lib integration #500

feat: rpc lib integration #500

andreabadesso commented Jun 24, 2024 •

edited

Loading

andreabadesso Jul 3, 2024

andreabadesso Jul 3, 2024

andreabadesso Jul 3, 2024

andreabadesso Jul 12, 2024

andreabadesso Jul 12, 2024

andreabadesso Jul 12, 2024

alexruzenhack left a comment

feat: rpc lib integration #500

feat: rpc lib integration #500

Conversation

andreabadesso commented Jun 24, 2024 • edited Loading

Acceptance Criteria

Security Checklist

andreabadesso Jul 3, 2024

Choose a reason for hiding this comment

andreabadesso Jul 3, 2024

Choose a reason for hiding this comment

andreabadesso Jul 3, 2024

Choose a reason for hiding this comment

andreabadesso Jul 12, 2024

Choose a reason for hiding this comment

andreabadesso Jul 12, 2024

Choose a reason for hiding this comment

andreabadesso Jul 12, 2024

Choose a reason for hiding this comment

alexruzenhack left a comment

Choose a reason for hiding this comment

andreabadesso commented Jun 24, 2024 •

edited

Loading