-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nano contract info to tx history [6] #434
Conversation
7235cb2
to
8d2950f
Compare
02af010
to
4f4c96e
Compare
The TokensHeader component is not using the new one. Besides that, everything meets the Design accordingly. |
9679e69
to
bff35f0
Compare
7e7efc1
to
7ec497c
Compare
5467f59
to
4aaa4c9
Compare
33457fb
to
bf5ce64
Compare
bf7b4db
to
e5599cd
Compare
locale/pt-br/texts.po
Outdated
msgid "Nano Contract Caller" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is interesting, what do you think about "Caller do Nano Contract"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ugly. I prefer "Acionador do Nano Contract" to avoid a heavy "foreignism" (estrangeirismo).
locale/pt-br/texts.po
Outdated
|
||
#: src/components/TxDetailsModal.js:106 | ||
msgid "Nano Contract Caller" | ||
msgstr "Acionador do Nano Contract" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the best person to discuss this translation with? Campana?
I don't like this translation, but I don't have anything better to suggest, so I'm going to approve this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it either. While we wait for the best names from the other areas, I think we can call "Endereço que assinou o Nano Contract", even if it's big, I think it's better.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to keep it as a noun we can use "Endereço de assinatura do Nano Contract".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, in our documentation about nano contracts, this field was named "caller", you can see in the diagram at:
https://beta-test.docs.hathor.network/explanations/features/nano-contracts/how-it-works#transactions
However, please note that this name was provided for two reasons:
- This is how Marcelo named it.
- It relates to who is indeed calling the contract.
Thus, it is the adequate term for documentation purposes.
That said, it might not be suitable in terms of UI/UX. Because I don't know the overall terminology of this and also other features in our UIs, is difficult to suggest something at this moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @BrunoCampana, thank you to add more light in this case. I got it!
Regarding the translation, do you do have a suggestion?
I found a better word for the translation so far: "Signatário"; see definition. I believe it is more aligned with all the explanation you showcased here @BrunoCampana. What do you guys say about this one?
* feat: add nano contract info to tx history
* feat: add nano contract info to tx history
* feat: add nano contract info to tx history
This change enables to show nano contract context information on regular transaction list and details. Also, it enables to set marks based on transaction type and make visual differentiation among them.
Look at the approved design #445. Go to "Flow 4".
Acceptance Criteria
TxHistory Screen:
TxDetails Modal (Nano Contract:
ActionDot to access token info
Note
It depends on:
Security Checklist