Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nano contract info to tx history [6] #434

Merged
merged 10 commits into from
May 3, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Feb 23, 2024

This change enables to show nano contract context information on regular transaction list and details. Also, it enables to set marks based on transaction type and make visual differentiation among them.

Look at the approved design #445. Go to "Flow 4".

Acceptance Criteria

  • should extract TxHistory construction to the model
  • should add nano contract information on tx details view
  • should change icon to access token info
TxHistory Screen:
TxDetails Modal (Nano Contract:
ActionDot to access token info

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-history branch 2 times, most recently from 7235cb2 to 8d2950f Compare March 5, 2024 16:14
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-tx-history branch from 02af010 to 4f4c96e Compare March 5, 2024 16:24
@anafigueired
Copy link

The TokensHeader component is not using the new one.

Besides that, everything meets the Design accordingly.

@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-history branch 2 times, most recently from 9679e69 to bff35f0 Compare March 27, 2024 15:51
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-tx-history branch from 7e7efc1 to 7ec497c Compare March 27, 2024 19:42
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-history branch 2 times, most recently from 5467f59 to 4aaa4c9 Compare March 30, 2024 18:41
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-tx-history branch from 33457fb to bf5ce64 Compare March 31, 2024 19:53
@alexruzenhack alexruzenhack changed the base branch from feat/nano-contract-history to feat/add-components April 5, 2024 17:42
@alexruzenhack alexruzenhack changed the base branch from feat/add-components to feat/nano-contract-history April 5, 2024 17:43
@alexruzenhack alexruzenhack changed the title feat: add nano contract info to tx history feat: add nano contract info to tx history [6] Apr 8, 2024
Base automatically changed from feat/nano-contract-history to master April 23, 2024 14:43
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-tx-history branch from bf7b4db to e5599cd Compare April 23, 2024 16:18
Comment on lines 1241 to 1242
msgid "Nano Contract Caller"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting, what do you think about "Caller do Nano Contract"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ugly. I prefer "Acionador do Nano Contract" to avoid a heavy "foreignism" (estrangeirismo).


#: src/components/TxDetailsModal.js:106
msgid "Nano Contract Caller"
msgstr "Acionador do Nano Contract"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the best person to discuss this translation with? Campana?

I don't like this translation, but I don't have anything better to suggest, so I'm going to approve this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it either. While we wait for the best names from the other areas, I think we can call "Endereço que assinou o Nano Contract", even if it's big, I think it's better.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep it as a noun we can use "Endereço de assinatura do Nano Contract".

Copy link
Member

@BrunoCampana BrunoCampana May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexruzenhack

At the moment, in our documentation about nano contracts, this field was named "caller", you can see in the diagram at:
https://beta-test.docs.hathor.network/explanations/features/nano-contracts/how-it-works#transactions

However, please note that this name was provided for two reasons:

  • This is how Marcelo named it.
  • It relates to who is indeed calling the contract.

Thus, it is the adequate term for documentation purposes.

That said, it might not be suitable in terms of UI/UX. Because I don't know the overall terminology of this and also other features in our UIs, is difficult to suggest something at this moment.

Copy link
Contributor Author

@alexruzenhack alexruzenhack May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @BrunoCampana, thank you to add more light in this case. I got it!

Regarding the translation, do you do have a suggestion?

I found a better word for the translation so far: "Signatário"; see definition. I believe it is more aligned with all the explanation you showcased here @BrunoCampana. What do you guys say about this one?

@pedroferreira1 pedroferreira1 requested review from BrunoCampana and removed request for BrunoCampana May 3, 2024 17:09
@alexruzenhack alexruzenhack merged commit 836e341 into master May 3, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the feat/nano-contract-tx-history branch May 3, 2024 21:47
@alexruzenhack alexruzenhack mentioned this pull request May 15, 2024
alexruzenhack added a commit that referenced this pull request May 15, 2024
* feat: add nano contract info to tx history
alexruzenhack added a commit that referenced this pull request May 15, 2024
* feat: add nano contract info to tx history
andreabadesso pushed a commit that referenced this pull request Jun 24, 2024
* feat: add nano contract info to tx history
@tuliomir tuliomir mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants