Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use rocksdb in the integration tests #819

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented Feb 26, 2025

Motivation

The next full node version will not support memory storage anymore and one of the nano contract indexes already doesn't support it. The main problem with using rocksdb is that the full node service takes more time to become healthy (with status port ready to receive requests), so the tx mining service and the test itself were breaking.

Then I created a healthcheck to validate if the node is already receiving http requests. I tried using curl or wget but the docker container doesn't have them installed, that's why it's using a python script to validate.

Acceptance Criteria

  • Use rocksdb in the fullnode that runs in the integration tests

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Feb 26, 2025
@pedroferreira1 pedroferreira1 force-pushed the tests/integration-tests-rocksdb branch from 21c193a to 3d31bba Compare February 26, 2025 15:42
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (13f2b4d) to head (de702e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #819   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          91       91           
  Lines        7190     7190           
  Branches     1507     1517   +10     
=======================================
  Hits         5826     5826           
  Misses       1351     1351           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tuliomir
tuliomir previously approved these changes Feb 26, 2025
r4mmer
r4mmer previously approved these changes Feb 26, 2025
@pedroferreira1 pedroferreira1 dismissed stale reviews from r4mmer and tuliomir via de702e9 February 26, 2025 21:34
@pedroferreira1 pedroferreira1 merged commit 9c78996 into master Feb 27, 2025
5 checks passed
@pedroferreira1 pedroferreira1 deleted the tests/integration-tests-rocksdb branch February 27, 2025 00:24
r4mmer added a commit that referenced this pull request Feb 27, 2025
…nd-to-storage

* origin/master:
  tests: use rocksdb in the integration tests (#819)
  feat: transaction template (#808)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants