-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement bigint support #728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acb3f0f
to
badafe5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 80.55% 80.72% +0.16%
==========================================
Files 81 85 +4
Lines 6471 6547 +76
Branches 1396 1421 +25
==========================================
+ Hits 5213 5285 +72
- Misses 1245 1249 +4
Partials 13 13 ☔ View full report in Codecov by Sentry. |
glevco
commented
Aug 1, 2024
badafe5
to
fde977c
Compare
efe15e4
to
c744d46
Compare
fde977c
to
6f9fa0c
Compare
c744d46
to
1b31680
Compare
6f9fa0c
to
6c44af7
Compare
1 task
1b31680
to
8cecc72
Compare
6c44af7
to
8ddab19
Compare
8cecc72
to
59e0572
Compare
6f6d928
to
c20d3cb
Compare
b23e32b
to
291b937
Compare
glevco
commented
Nov 14, 2024
4f6195a
to
ed121c6
Compare
1 task
r4mmer
reviewed
Nov 25, 2024
2 tasks
pedroferreira1
approved these changes
Nov 26, 2024
r4mmer
approved these changes
Dec 3, 2024
9ef97a7
to
1e6331e
Compare
r4mmer
added a commit
that referenced
this pull request
Dec 13, 2024
* origin/master: feat: add support for max output values (#708) chore: remove support for Node v20 (#799) feat: implement bigint support (#728) feat: consider nano caller to the address metadata in the storage (#801) chore(deps): bump axios from 1.7.2 to 1.7.7 (#752) ci: add support for node v22 (#797)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #797
Motivation
See https://github.com/HathorNetwork/internal-issues/issues/363.
This PR adds the necessary structures to support bigint fields, however it does not yet change the
OutputValueType
tobigint
.Acceptance Criteria
bigIntToBytes()
and removesignedIntToBytes()
support for 8 bytes.unpackToBigInt()
and removeunpackToInt()
support for 8 bytes.bytesToOutputValue()
to useunpackToBigInt()
.zod
.level-transcoder
was added explicitly but was already an indirect dependency.long
.api/txApi
andapi/wallet
Zod schemas, updating requests to usetransformJsonBigIntResponse()
.Output.valueToBytes()
to usebigIntToBytes()
instead ofsignedIntToBytes()
.jsonBigIntEncoding()
where necessary.utils/bigint.ts
.JSONBigInt.parse()
instead ofJSON.parse()
.es2020
instead ofes2018
, adding support forbigint
.Security Checklist