-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: streaming history sync #706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
===========================================
+ Coverage 63.52% 80.42% +16.90%
===========================================
Files 77 78 +1
Lines 5957 6156 +199
Branches 1303 1341 +38
===========================================
+ Hits 3784 4951 +1167
+ Misses 2075 1187 -888
+ Partials 98 18 -80 ☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Jul 17, 2024
msbrogli
requested changes
Jul 17, 2024
glevco
reviewed
Jul 23, 2024
glevco
previously approved these changes
Jul 23, 2024
msbrogli
previously approved these changes
Jul 23, 2024
msbrogli
previously approved these changes
Jul 23, 2024
glevco
approved these changes
Jul 23, 2024
msbrogli
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamming history sync
The client will send a
request:history:<method>
where method is eitherxpub
ormanual
to start syncing the history of a wallet through the websocket connection with the fullnode.The difference between
xpub
andmanual
modes is that inxpub
mode we send the xpubkey and the addresses are derived on the fullnode and onmanual
mode we derive the addresses and send the list of addresses the fullnode has to iterate over.Once the stream starts the fullnode will start streaming the addresses and history.
It will send
stream:history:address
with an address, this marks the end of the history from the last address.All transactions after this will be on this address history (until the next address event is received).
It will send
stream:history:vertex
with a transaction on the wallet history.It will send
stream:history:end
when all addresses and transactions were sent.It will send a
stream:history:error
when an error happens on the fullnode and we should stop the streamming.Acceptance Criteria
Security Checklist