style: Least intrusive lint rules #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
force-pushed
the
style/lint-least-intrusive
branch
from
a804c6b to
58b352e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
===========================================
+ Coverage 62.82% 79.69% +16.87%
===========================================
Files 77 77
Lines 5928 5935 +7
Branches 1284 1286 +2
===========================================
+ Hits 3724 4730 +1006
+ Misses 2106 1187 -919
+ Partials 98 18 -80 ☔ View full report in Codecov by Sentry. |
r4mmer
requested changes
Jun 19, 2024
src/api/axiosWrapper.ts
Outdated
| resolve?: Function | null, | ||
| timeout?: number | null, | ||
| additionalHeaders = {} | ||
| resolve?: undefined | null, // XXX: We should remove or use this parameter |
There was a problem hiding this comment.
We should remove if it is not used
There was a problem hiding this comment.
This would be a breaking change to a method that is used in many places, both in the lib and in its clients: I took the path of just mapping the situation instead of acting now.
Do you agree with this approach?
r4mmer
previously approved these changes
Jun 26, 2024
andreabadesso
previously approved these changes
Jun 26, 2024
Without a target to at least es2018, AsyncGenerator usage would trigger `no-undef` errors.
tuliomir
force-pushed
the
style/lint-least-intrusive
branch
from
de3e775 to
44bea46
Compare
r4mmer
approved these changes
Jun 28, 2024
andreabadesso
approved these changes
Jun 28, 2024
r4mmer
added a commit
that referenced
this pull request
Jun 29, 2024
…-config * origin/master: style: Least intrusive lint rules (#679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
eslint-disable-*command should have a comment explaining why it was usedNote
To fix the
no-undefrule it was necessary to upgradetsconfig.jsontarget fromes6toes2018.Security Checklist