Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds eslint for ts and js files #669

Merged
merged 5 commits into from
Jun 17, 2024
Merged

feat: Adds eslint for ts and js files #669

merged 5 commits into from
Jun 17, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Jun 13, 2024

Acceptance Criteria

  • Adds eslint configuration for all of the project code
  • Adds scripts on the package.json for easy linting, formatting and error fixing

Notes

A .eslintrc file already existed in the repository and was being used to lint the integration test files. The rules on this file were preserved, and it was only moved to a js structure for improved maintenance convenience.

A newer major version of Eslint is available, but has some incompatibilities with some of our other dependencies. This is being tracked by:

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the enhancement New feature or request label Jun 13, 2024
@tuliomir tuliomir requested a review from andreabadesso June 13, 2024 15:57
@tuliomir tuliomir self-assigned this Jun 13, 2024
@tuliomir tuliomir requested a review from pedroferreira1 as a code owner June 13, 2024 15:57
@tuliomir tuliomir force-pushed the feat/eslint-configs branch from f28a9f6 to 6c59cf2 Compare June 13, 2024 16:00
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (28e5ff2) to head (2146330).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #669       +/-   ##
===========================================
+ Coverage   62.79%   79.73%   +16.93%     
===========================================
  Files          77       77               
  Lines        5886     5886               
  Branches     1242     1242               
===========================================
+ Hits         3696     4693      +997     
+ Misses       2094     1176      -918     
+ Partials       96       17       -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir force-pushed the feat/eslint-configs branch 3 times, most recently from 2e2ac6d to 9c8e433 Compare June 14, 2024 00:08
@tuliomir tuliomir requested a review from andreabadesso June 14, 2024 00:27
@tuliomir tuliomir force-pushed the feat/eslint-configs branch from 9c8e433 to 2146330 Compare June 17, 2024 21:05
@tuliomir tuliomir merged commit 76bb097 into master Jun 17, 2024
4 checks passed
@tuliomir tuliomir deleted the feat/eslint-configs branch June 17, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants