-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds eslint
for ts
and js
files
#669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f28a9f6
to
6c59cf2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
===========================================
+ Coverage 62.79% 79.73% +16.93%
===========================================
Files 77 77
Lines 5886 5886
Branches 1242 1242
===========================================
+ Hits 3696 4693 +997
+ Misses 2094 1176 -918
+ Partials 96 17 -79 ☔ View full report in Codecov by Sentry. |
andreabadesso
requested changes
Jun 13, 2024
2e2ac6d
to
9c8e433
Compare
andreabadesso
approved these changes
Jun 17, 2024
pedroferreira1
approved these changes
Jun 17, 2024
9c8e433
to
2146330
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
eslint
configuration for all of the project codepackage.json
for easy linting, formatting and error fixingNotes
A
.eslintrc
file already existed in the repository and was being used to lint the integration test files. The rules on this file were preserved, and it was only moved to ajs
structure for improved maintenance convenience.A newer major version of Eslint is available, but has some incompatibilities with some of our other dependencies. This is being tracked by:
Security Checklist