Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow private networks #277

Closed
wants to merge 3 commits into from
Closed

feat: allow private networks #277

wants to merge 3 commits into from

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Oct 7, 2021 •
edited
Loading

Acceptance Criteria

  • It should be possible to use this version of the lib in our Explorer and make it work with private-networks
  • Allow dynamically adding more network configuration options

Notes

  • We are using the same version bytes as the Testnet for the private networks, because we would have problems with TxMiningService if using different ones, since it validates the addresses.

TODO

@luislhl luislhl changed the base branch from master to dev October 7, 2021 17:55
@luislhl luislhl self-assigned this Oct 7, 2021
luislhl
luislhl commented Oct 8, 2021
View reviewed changes
luislhl
luislhl commented Oct 27, 2021
View reviewed changes
@luislhl luislhl force-pushed the feat/allow-private-networks branch from eb2b08f to 3250972 Compare November 4, 2021 20:40
@luislhl luislhl mentioned this pull request Nov 5, 2021
Closed
2 tasks
@luislhl luislhl requested a review from msbrogli November 5, 2021 19:58
luislhl
luislhl commented Nov 10, 2021
View reviewed changes
src/models/network.ts
*
* We validate the configuration before registering.
*/
static registerNetwork(networkConfig: networkConfigType) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to a different PR, because we should test it further

@luislhl luislhl mentioned this pull request Nov 11, 2021
Merged
3 tasks
@luislhl
Copy link
Contributor Author

luislhl commented Nov 11, 2021

Split into 2 new PRs: #286 and #287

@luislhl luislhl closed this Nov 11, 2021
@luislhl luislhl deleted the feat/allow-private-networks branch November 11, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbrogli msbrogli msbrogli approved these changes

@pedroferreira1 pedroferreira1 Awaiting requested review from pedroferreira1

Assignees

@luislhl luislhl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luislhl @msbrogli