Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script to get multisig xpub from seed easily #520

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Feb 11, 2025

Acceptance Criteria

  • We should be able to run make multisig_xpub_from_seed seed="<seed words>" to get a multisig xpub from seed

Motivation

  • Some people were mistakenly using make xpub_from_seed for this.
  • It will make it easier to generate a multisig xpub in automated environments

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Feb 11, 2025
@luislhl luislhl requested review from r4mmer and tuliomir and removed request for pedroferreira1 February 11, 2025 13:45
r4mmer
r4mmer previously approved these changes Feb 11, 2025
@luislhl luislhl changed the title feat: script to get multisig xpub frmo seed easily feat: script to get multisig xpub from seed easily Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (1d1c899) to head (cf410e2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          54       54           
  Lines        2325     2325           
  Branches      439      439           
=======================================
  Hits         2097     2097           
  Misses        211      211           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tuliomir
tuliomir previously approved these changes Feb 12, 2025
@luislhl luislhl dismissed stale reviews from tuliomir and r4mmer via cf410e2 February 12, 2025 19:24
@luislhl luislhl merged commit a3dde5c into master Feb 14, 2025
8 checks passed
@luislhl luislhl deleted the feat/script-get-multisig-xpub branch February 14, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants