Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing parameters in nano contract API #499

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

pedroferreira1
Copy link
Member

Acceptance Criteria

  • Add before query parameter to the nano contract history API.
  • Add block_hash and block_height query parameters to the nano contract state API.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Oct 10, 2024
r4mmer
r4mmer previously approved these changes Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (332c7ce) to head (f8b5c1b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          54       54           
  Lines        2307     2307           
  Branches      435      435           
=======================================
  Hits         2078     2078           
  Misses        212      212           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

luislhl
luislhl previously approved these changes Oct 10, 2024
@pedroferreira1 pedroferreira1 merged commit 3a8bd9c into master Oct 15, 2024
8 checks passed
@pedroferreira1 pedroferreira1 deleted the feat/add-missing-nc-api-params branch October 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants