-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: google cloud platform pubsub plugin integration #450
base: master
Are you sure you want to change the base?
Conversation
@Ikari the PR is approved, it just needs a rebase so we can continue with the merge |
Rebased! |
@Ikari we've fixed a bug in codecov, so we can make the CI succeed. Can you do one more rebase please, to update your branch, so we can check if the CI completes? |
…n the env only accepts strings
Co-authored-by: Luis Helder <[email protected]>
@pedroferreira1 sure thing, branch updated. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 89.53% 89.04% -0.50%
==========================================
Files 51 52 +1
Lines 2151 2163 +12
Branches 406 409 +3
==========================================
Hits 1926 1926
- Misses 208 217 +9
- Partials 17 20 +3 ☔ View full report in Codecov by Sentry. |
This PR have two changes:
src/controllers/index.controller.js Ln 100-101: