Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e tests to multisig extension endpoints #317

Merged
merged 3 commits into from
Jul 26, 2023
Merged

test: add e2e tests to multisig extension endpoints #317

merged 3 commits into from
Jul 26, 2023

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Jun 27, 2023 •
edited
Loading

Acceptance Criteria

  • test: implement e2e tests for create, mint, melt and decode endpoints

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Depends on:

Closes: #316

@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from 22d7d15 to 4c4051b Compare June 27, 2023 20:45
@alexruzenhack alexruzenhack requested a review from r4mmer June 27, 2023 20:45
@alexruzenhack alexruzenhack self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #317 (e3dd87e) into dev (d761633) will decrease coverage by 0.14%.
Report is 1 commits behind head on dev.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
- Coverage   87.47%   87.33%   -0.14%     
==========================================
  Files          35       35              
  Lines        1405     1429      +24     
  Branches      292      296       +4     
==========================================
+ Hits         1229     1248      +19     
- Misses        155      160       +5     
  Partials       21       21
Files Changed Coverage Δ
src/api-docs.js 100.00% <ø> (ø)
src/helpers/tx.helper.js 90.47% <63.63%> (-5.68%) ⬇️
src/controllers/wallet/wallet.controller.js 87.68% <94.44%> (+0.18%) ⬆️

@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch 2 times, most recently from 829704a to d65d575 Compare June 27, 2023 23:21
@alexruzenhack alexruzenhack marked this pull request as draft June 27, 2023 23:49
r4mmer
r4mmer reviewed Jul 4, 2023
View reviewed changes
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from d65d575 to c2b4c07 Compare July 10, 2023 13:36
@alexruzenhack alexruzenhack changed the base branch from dev to feat/extend-wallet-decode-endpoin July 10, 2023 13:37
@alexruzenhack alexruzenhack force-pushed the feat/extend-wallet-decode-endpoin branch 2 times, most recently from e44b74c to 3738a21 Compare July 11, 2023 21:20
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from c2b4c07 to 00b0314 Compare July 12, 2023 17:02
@alexruzenhack alexruzenhack force-pushed the feat/extend-wallet-decode-endpoin branch from 3738a21 to c919096 Compare July 12, 2023 17:19
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch 2 times, most recently from 52b4c81 to 1ad70d7 Compare July 12, 2023 17:29
@alexruzenhack alexruzenhack force-pushed the feat/extend-wallet-decode-endpoin branch 2 times, most recently from e9d91a9 to 8eb9990 Compare July 12, 2023 18:22
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from 1ad70d7 to 1e2b2ba Compare July 12, 2023 18:38
@alexruzenhack alexruzenhack force-pushed the feat/extend-wallet-decode-endpoin branch from 8eb9990 to 18b1c73 Compare July 12, 2023 18:42
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from 1e2b2ba to 28a4cf1 Compare July 12, 2023 18:43
@alexruzenhack alexruzenhack marked this pull request as ready for review July 12, 2023 18:50
@alexruzenhack alexruzenhack requested review from r4mmer and tuliomir July 12, 2023 18:51
@alexruzenhack alexruzenhack mentioned this pull request Jul 14, 2023
Open
@alexruzenhack alexruzenhack force-pushed the feat/extend-wallet-decode-endpoin branch from fd1b871 to 809533d Compare July 20, 2023 15:09
tuliomir
tuliomir reviewed Jul 20, 2023
View reviewed changes
Base automatically changed from feat/extend-wallet-decode-endpoin to dev July 21, 2023 12:40
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch 3 times, most recently from 27412bb to 30a6b53 Compare July 24, 2023 13:22
@alexruzenhack
test: add e2e test for multisig extension
7415e59 
refactor: remove input.data

chore: add mint-tokens to api-docs

refactor: add attribute signTx as false

chore: fix api-docs

chore: fix api-docs

feat: add melt-tokens endpoint for p2sh wallet

chore: add melt-tokens to api-docs

chore: add error instrumentation

chore: add metadata to decode endpoint

chore: add metadata to decode endpoint

test: add e2e tests for for create, mint, melt and decode endpoints

chore: add token_data property to enable balance operation

test: adjust tests to decode metadata

chore: lint

chore: simplify buildCreateToken

chore: add explanation to token_data property duplication

chore: apply review suggestions

chore: resolve lint and tests issues
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from 30a6b53 to 7415e59 Compare July 24, 2023 13:24
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch 2 times, most recently from e137020 to df53d22 Compare July 24, 2023 20:56
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from df53d22 to ea13ad3 Compare July 25, 2023 11:55
@alexruzenhack alexruzenhack force-pushed the test/e2e-multisig-extension branch from ea13ad3 to e3dd87e Compare July 25, 2023 20:27
@alexruzenhack alexruzenhack merged commit 22a77ba into dev Jul 26, 2023
@alexruzenhack alexruzenhack deleted the test/e2e-multisig-extension branch July 26, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@r4mmer r4mmer r4mmer approved these changes

@pedroferreira1 pedroferreira1 Awaiting requested review from pedroferreira1

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
Merge MultiSig for bridge
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @tuliomir @r4mmer