feat: Upgrades react-scripts to v5
#386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
force-pushed
the
feat/upgrades-cra-5
branch
from
f9e3c23 to
f345855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This repository was still using React Scripts v3 and the upgrade to v4 was facing problems complicated enough that it was not being worth the effort to add this intermediary step. So, a decision was made to jump directly to v5.
This decision considered the tradeoffs discussed in HathorNetwork/hathor-wallet#441 and took advantage of know-how acquired in HathorNetwork/hathor-wallet#712 to greatly decrese the effort needed for this upgrade.
Acceptance Criteria
react-scriptsfrom v3 to v5Security Checklist