feat: add blueprint list #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
force-pushed
the
feat/blueprint-list
branch
from
ac6a1e0 to
409afab
Compare
pedroferreira1
commented
Feb 17, 2025
Comment on lines
-153
to
+158
| return 'page-item active'; | ||
| return 'page-item'; |
There was a problem hiding this comment.
Ana decided to remove the active style from table pagination buttons, so both pagination buttons have the same style now.
tuliomir
previously approved these changes
Feb 19, 2025
Comment on lines
+5
to
+7
| // XXX We should use function component with SortableTable as a component | ||
| // but renderTableHead and renderTableBody are implemented and not | ||
| // expected as a props, so it demands a bigger refactor |
There was a problem hiding this comment.
⭐ Thanks for highlighting this tech debt here! This is pending since before the UX revamp.
pedroferreira1
force-pushed
the
feat/blueprint-list
branch
from
2c22e13 to
ac00559
Compare
tuliomir
previously approved these changes
Feb 22, 2025
r4mmer
reviewed
Feb 24, 2025
r4mmer
approved these changes
Feb 25, 2025
tuliomir
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
blueprint.list.1.mov
blueprint.list.2.mov
Security Checklist