Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added token balances page and integration with elasticsearch #197

Merged
merged 27 commits into from
Jun 6, 2022
Merged

feat: added token balances page and integration with elasticsearch #197

merged 27 commits into from
Jun 6, 2022

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented May 30, 2022 •
edited
Loading

Implements the UI at HathorNetwork/hathor-explorer-service#156

TokenBalances.mp4

Acceptance criteria

  • We should have a new token balances page that displays sortable addresses and their balances (total, locked and unlocked) for a given token_id
  • We should have an autocomplete field to search for tokens by name, symbol and uid using the tokens api

@andreabadesso andreabadesso requested a review from r4mmer as a code owner May 30, 2022 17:14
@andreabadesso andreabadesso self-assigned this May 30, 2022
@andreabadesso andreabadesso added the enhancement New feature or request label May 30, 2022
@andreabadesso andreabadesso force-pushed the feat/token-balances-ui branch from 22ffa37 to 71661be Compare June 1, 2022 01:58
@andreabadesso andreabadesso force-pushed the feat/token-balances-ui branch from 2c450fa to 2cd52b2 Compare June 1, 2022 02:26
@andreabadesso andreabadesso force-pushed the feat/token-balances-ui branch from b3b994c to fce77bb Compare June 2, 2022 16:32
@andreabadesso andreabadesso force-pushed the feat/token-balances-ui branch from 6b79dec to f842305 Compare June 2, 2022 16:36
@andreabadesso andreabadesso requested review from lucas3003 and luislhl and removed request for r4mmer June 2, 2022 17:39
luislhl
luislhl reviewed Jun 3, 2022
View reviewed changes
luislhl
luislhl reviewed Jun 3, 2022
View reviewed changes
luislhl
luislhl reviewed Jun 3, 2022
View reviewed changes
@andreabadesso andreabadesso force-pushed the feat/token-balances-ui branch from c67608b to af10ac6 Compare June 3, 2022 21:30
luislhl
luislhl previously approved these changes Jun 3, 2022
View reviewed changes
lucas3003
lucas3003 previously approved these changes Jun 4, 2022
View reviewed changes
@andreabadesso andreabadesso dismissed stale reviews from lucas3003 and luislhl via 9930d85 June 5, 2022 16:28
@andreabadesso
Copy link
Contributor Author

@luislhl @lucas3003
I had to fix a typo on the navigation on this commit: 9930d85

Can you please approve again? Github removed your approvals

Thanks

@pedroferreira1 pedroferreira1 merged commit bc9256f into dev Jun 6, 2022
@pedroferreira1 pedroferreira1 deleted the feat/token-balances-ui branch June 6, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas3003 lucas3003 lucas3003 approved these changes

@luislhl luislhl luislhl approved these changes

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreabadesso @luislhl @lucas3003 @pedroferreira1