Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add handler to nc creation list API #358

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented Feb 19, 2025

Acceptance Criteria

  • Add handler for hathor core nano creation list API.
  • Update all 3 APIs to substitute the find parameters for search parameter.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Feb 19, 2025
cors: true
caching:
enabled: true
ttlInSeconds: 300
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: This time period is approximately 10 blocks at our current config. Does this mean a new nano-contract will have to wait up to this time to be displayed in the search results/api responses?

If so, this time seems a bit too high for this specific feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review (WIP)
Development

Successfully merging this pull request may close these issues.

2 participants