Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertex_handler): Improve new vertex log #1224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msbrogli
Copy link
Member

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner February 14, 2025 19:10
@msbrogli msbrogli self-assigned this Feb 14, 2025
Copy link

🐰 Bencher Report

Branchfeat/improve-new-vertex-log
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.52
(-7.19%)Baseline: 1.63
1.47
(96.98%)
1.80
(84.37%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (91e2bd8) to head (64fdaed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   84.47%   84.42%   -0.06%     
==========================================
  Files         320      320              
  Lines       24559    24563       +4     
  Branches     3762     3764       +2     
==========================================
- Hits        20747    20738       -9     
- Misses       3077     3085       +8     
- Partials      735      740       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (WIP)
Development

Successfully merging this pull request may close these issues.

1 participant