-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ws): Slow empty address verification on address subscription #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
commented
Jan 14, 2025
|
Branch | fix/ws-slow-empty-addr-verification |
Testbed | ubuntu-22.04 |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.50 (-9.11%) | 1.49 (99.02%) | 1.82 (82.63%) |
d6cc87e
to
865837a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
- Coverage 83.63% 83.58% -0.06%
==========================================
Files 320 320
Lines 24540 24551 +11
Branches 3762 3764 +2
==========================================
- Hits 20524 20520 -4
- Misses 3255 3267 +12
- Partials 761 764 +3 ☔ View full report in Codecov by Sentry. |
glevco
reviewed
Jan 14, 2025
865837a
to
45937c1
Compare
45937c1
to
a3bf50c
Compare
glevco
approved these changes
Jan 23, 2025
jansegre
approved these changes
Jan 23, 2025
This was referenced Feb 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of empty addresses was too slow. It was running in O(n) where n is the number of subscribed addresses. So, the time complexity to load a wallet was O(n^2) because the check was executed for each address.
This PR reduces the time complexity to O(m) where m is the number of empty addresses. So, the load time is reduced to O(nm). Notice that
m < n / gap_limit
.Acceptance Criteria
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged