-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexes): remove sync-v1 indexes #1200
Open
jansegre
wants to merge
17
commits into
feat/consensus-change
Choose a base branch
from
feat/remove-sync-v1-indexes
base: feat/consensus-change
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch | feat/remove-sync-v1-indexes |
Testbed | ubuntu-22.04 |
🚨 1 Alert
Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 1.42 (-14.30%) | 1.49 (105.02%) |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 1.42 (-14.30%) | 1.49 (105.02%) | 1.82 (77.91%) |
b6bdf57
to
0e6013a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/consensus-change #1200 +/- ##
=========================================================
- Coverage 83.57% 83.55% -0.03%
=========================================================
Files 320 317 -3
Lines 24534 24222 -312
Branches 3756 3699 -57
=========================================================
- Hits 20504 20238 -266
+ Misses 3266 3232 -34
+ Partials 764 752 -12 ☔ View full report in Codecov by Sentry. |
0e6013a
to
752b56a
Compare
0a38b06
to
ea7d72c
Compare
752b56a
to
cbfd6f1
Compare
This was referenced Jan 29, 2025
chore: bump version to v0.63.1
Release-candidate v0.63.1-rc.1
Release v0.63.1
fix(cli): regression on `run_node --help`
fix(metrics): websocket metrics was not being updated
Co-authored-by: Jan Segre <[email protected]>
cbfd6f1
to
105ee8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After removing sync-v1 (#1197) and removing block ties (#673) there is no need to have the sync-v1 indexes (tx-tips, block-tips and all-tips). There should be a slight runtime benefit (no measurement has been made), but more noticeably, there will be a substantial improvement in startup time.
Acceptance Criteria
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged