-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(side-dag): implement PoaBlockProducer #1061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
commented
Jun 11, 2024
d8b4f9c
to
c18954f
Compare
b8937d7
to
0baac09
Compare
ca6e9c1
to
df2dd9f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
==========================================
- Coverage 84.92% 84.62% -0.30%
==========================================
Files 307 308 +1
Lines 23177 23295 +118
Branches 3503 3518 +15
==========================================
+ Hits 19683 19714 +31
- Misses 2792 2870 +78
- Partials 702 711 +9 ☔ View full report in Codecov by Sentry. |
d9fba8c
to
7927972
Compare
1 task
msbrogli
requested changes
Jun 13, 2024
This was referenced Jun 13, 2024
jansegre
previously approved these changes
Jun 13, 2024
8985bae
to
4e359f5
Compare
a750cbd
to
e543cbb
Compare
1 task
e543cbb
to
8d39404
Compare
msbrogli
reviewed
Jul 5, 2024
msbrogli
reviewed
Jul 5, 2024
8d39404
to
b525727
Compare
msbrogli
approved these changes
Jul 12, 2024
b525727
to
b85b855
Compare
jansegre
approved these changes
Jul 13, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1060
Motivation
Finish the Proof-of-Authority side-dag implementation by implementing the
PoaBlockProducer
which is analogous to a mining service, in the full node itself.Acceptance Criteria
poa
module andPoaBlockProducer
.gen_genesis
CLI command.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged