Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(side-dag): implement PoaBlockProducer #1061

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 11, 2024

Depends on #1060

Motivation

Finish the Proof-of-Authority side-dag implementation by implementing the PoaBlockProducer which is analogous to a mining service, in the full node itself.

Acceptance Criteria

  • Implement poa module and PoaBlockProducer.
  • Implement gen_genesis CLI command.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jun 11, 2024
@glevco glevco force-pushed the feat/side-dag/poa branch from d8b4f9c to c18954f Compare June 11, 2024 18:30
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from b8937d7 to 0baac09 Compare June 11, 2024 18:35
@glevco glevco marked this pull request as ready for review June 11, 2024 18:57
@glevco glevco requested review from jansegre and msbrogli as code owners June 11, 2024 18:57
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from ca6e9c1 to df2dd9f Compare June 11, 2024 21:30
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 47.51773% with 74 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (7c7c261) to head (b85b855).

Files Patch % Lines
hathor/consensus/poa/poa_block_producer.py 27.05% 62 Missing ⚠️
hathor/builder/cli_builder.py 14.28% 5 Missing and 1 partial ⚠️
hathor/manager.py 33.33% 2 Missing and 2 partials ⚠️
hathor/consensus/poa/poa_signer.py 83.33% 1 Missing ⚠️
hathor/mining/block_template.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   84.92%   84.62%   -0.30%     
==========================================
  Files         307      308       +1     
  Lines       23177    23295     +118     
  Branches     3503     3518      +15     
==========================================
+ Hits        19683    19714      +31     
- Misses       2792     2870      +78     
- Partials      702      711       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch 3 times, most recently from d9fba8c to 7927972 Compare June 11, 2024 22:49
jansegre
jansegre previously approved these changes Jun 13, 2024
@glevco glevco force-pushed the feat/side-dag/poa branch from 8985bae to 4e359f5 Compare June 20, 2024 13:38
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from a750cbd to e543cbb Compare June 20, 2024 13:41
@glevco glevco force-pushed the feat/side-dag/poa branch from 4e359f5 to c8b6ed1 Compare July 5, 2024 17:56
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from e543cbb to 8d39404 Compare July 5, 2024 17:57
@glevco glevco force-pushed the feat/side-dag/poa branch from c8b6ed1 to 701491c Compare July 8, 2024 14:25
Base automatically changed from feat/side-dag/poa to master July 8, 2024 15:11
@glevco glevco dismissed jansegre’s stale review July 8, 2024 15:11

The base branch was changed.

@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from 8d39404 to b525727 Compare July 8, 2024 21:22
@glevco glevco force-pushed the feat/side-dag/poa-block-producer branch from b525727 to b85b855 Compare July 12, 2024 23:16
@glevco glevco merged commit 5a788d0 into master Jul 15, 2024
12 checks passed
@glevco glevco deleted the feat/side-dag/poa-block-producer branch July 15, 2024 15:40
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants