feat: dapp adjustments #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
requested review from
luislhl and
alexruzenhack
and removed request for
luislhl
andreabadesso
commented
Oct 30, 2024
Comment on lines
+183
to
+200
| GlobalSecondaryIndexes: [ | ||
| { | ||
| IndexName: 'CreatorAddressIndex', | ||
| KeySchema: [ | ||
| { | ||
| AttributeName: 'creatorAddress', | ||
| KeyType: 'HASH', | ||
| } | ||
| ], | ||
| Projection: { | ||
| ProjectionType: 'ALL' | ||
| }, | ||
| ProvisionedThroughput: { // Required for DynamoDB Local | ||
| ReadCapacityUnits: 5, | ||
| WriteCapacityUnits: 5 | ||
| } | ||
| } | ||
| ], |
There was a problem hiding this comment.
@luislhl I added this so we can test locally, but I've opened the PR to add this secondary index to the production dynamodb table:
andreabadesso
requested review from
luislhl and
alexruzenhack
and removed request for
alexruzenhack and
luislhl
alexruzenhack
approved these changes
Nov 4, 2024
luislhl
approved these changes
Nov 5, 2024
andreabadesso
force-pushed
the
feat/dapp-adjustments
branch
from
a73adfa to
140098f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria