feat: UI for all screens #2
Conversation
andreabadesso
requested review from
alexruzenhack
and removed request for
pedroferreira1
| <Button className="bg-hathor-purple-500 w-full text-white max-w-md mt-12 h-12 text-md"> | ||
| Set result | ||
| </Button> |
There was a problem hiding this comment.
question: Shouldn't it be conditional to user's wallet address connected?
|
|
||
| return ( | ||
| <main className="flex min-h-screen items-center p-6 flex-col"> | ||
| <Header logo={false} title='Betting' subtitle="Olympic Games - Men's Football Finals" /> |
There was a problem hiding this comment.
question: Shouldn't the "Olympic Games - Men's Football Finals" text be dynamic? Isn't it the Nano Contract name?
| defaultValues: { | ||
| name: '', | ||
| description: '', | ||
| oracleType: 'random', |
There was a problem hiding this comment.
question: What an oracleType 'random' means?
| <div className='bg-black '> | ||
| </div> |
There was a problem hiding this comment.
question: Where is the image? Shouldn't it be among the project's assests?
| <Button className='bg-hathor-purple-500 w-full text-white text-md h-12'>Collect your prize</Button> | ||
|
|
There was a problem hiding this comment.
question: Shouldn't it be conditional to the winner address?
| return ( | ||
| <div className='flex justify-between w-full max-w-md'> | ||
| <p className='text-md subpixel-antialiased'>Total Bet</p> | ||
| <p className='text-md subpixel-antialiased'>200 EVC</p> |
| cell: ({ row }) => RowCapitalizeFirst(formatDate(row.getValue('timestamp'))), | ||
| }]; |
There was a problem hiding this comment.
polish: Timestamp doesn't need capitalize, maybe you can use the value directly.
| const SortableTableHeader = (name: string, column: Column<TransactionHistoryItem, unknown>) => { | ||
| const Arrow = (sorted: false | string) => { | ||
| console.log('sorted', sorted); | ||
| switch(sorted) { | ||
| case 'asc': | ||
| return <ArrowUp className="ml-2 h-4 w-4 text-hathor-purple-500" /> | ||
| case 'desc': | ||
| return <ArrowDown className="ml-2 h-4 w-4 text-hathor-purple-500" /> | ||
| default: | ||
| return <ArrowUpDown className="ml-2 h-4 w-4 text-hathor-purple-500" /> | ||
| } | ||
| }; |
There was a problem hiding this comment.
suggestion: Remove as it is not used.
I'm setting it as a suggestion because I don't really think it is the case to block the PR because of it.
| <TableHead key={header.id}> | ||
| {header.isPlaceholder | ||
| ? null | ||
| : flexRender( |
| const connected = false; | ||
| const [connected, setConnected] = React.useState<boolean>(false); | ||
| const onConnect = (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
question: Why should we prevent default behavior here?
Acceptance Criteria