Skip to content

Refactor/surface ray trace#516

Merged
HarrisonKramer merged 5 commits intomasterfrom
refactor/surface_ray_trace
Mar 12, 2026
Merged

Refactor/surface ray trace#516
HarrisonKramer merged 5 commits intomasterfrom
refactor/surface_ray_trace

Conversation

@HarrisonKramer
Copy link
Owner

  • minor refactor to make ray tracing in standard surface use polymorphism for ray types, rather than using isinstance checks
  • no change to user-facing API

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 95.75758% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
optiland/multiconfig/multi_configuration.py 25.00% 3 Missing ⚠️
optiland/rays/base.py 50.00% 2 Missing ⚠️
optiland/fields/field_types/base.py 94.73% 1 Missing ⚠️
optiland/optic/optic.py 96.55% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   93.08%   93.25%   +0.17%     
==========================================
  Files         316      318       +2     
  Lines       18716    18771      +55     
==========================================
+ Hits        17421    17505      +84     
+ Misses       1295     1266      -29     
Files with missing lines Coverage Δ
optiland/analysis/jones_pupil.py 96.66% <100.00%> (ø)
optiland/fields/field_types/angle.py 100.00% <100.00%> (ø)
optiland/fields/field_types/object_height.py 66.66% <100.00%> (+1.14%) ⬆️
...tiland/fields/field_types/paraxial_image_height.py 77.46% <100.00%> (+0.32%) ⬆️
optiland/fields/field_types/real_image_height.py 96.29% <100.00%> (+0.03%) ⬆️
optiland/optic/__init__.py 100.00% <100.00%> (ø)
optiland/optic/optic_serializer.py 100.00% <100.00%> (ø)
optiland/optimization/variable/asphere_coeff.py 100.00% <100.00%> (ø)
optiland/optimization/variable/conic.py 100.00% <100.00%> (ø)
optiland/optimization/variable/index.py 100.00% <100.00%> (ø)
... and 15 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HarrisonKramer HarrisonKramer merged commit db57022 into master Mar 12, 2026
14 checks passed
@HarrisonKramer HarrisonKramer deleted the refactor/surface_ray_trace branch March 12, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant