Gcp/service/cloud iam#357
Conversation
Sundi202
left a comment
There was a problem hiding this comment.
You have too many attributes such as id, display name ,description etc marked as security related in your docs when they are not security related. Please correct this and only add c and nc values for security relevant attributes. Location should be australia for this project. Just a friendly reminder please go through your entire work and correct the service where relevant because too much time is spent commenting on mistakes that can be avoided. Further review will be addressed when comments are resolved.
Note: : Comments should be addressed throughout your work, if you fix an error in one area, make sure it's not still appearing in the sections that follow.
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
|
All the changes you requested done. Thanks. |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
JBarazani
left a comment
There was a problem hiding this comment.
Hi Thanuka
At present I will not approve this PR as I still see some issues with it.
Given we are in week 12, and this PR has gone though 5+ rounds of review, I would like us to leave it as is.
I have no concerns about you passing the unit even without the merge, as you have made quite a few good policies as well, there are just other things that require fixing before this can be merged, and will likely give it other a Snr next trimester to pick up and fix based on my feedback.



No description provided.