Extend publishing functionality #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow multiple publishers per build, separate the publishing function into its own space, and add sftp/cp examples. While there, make use of clean room builds in hbsd-update-build and remove the assumption that all published builds must be signed (here be dragons).
xmj
force-pushed
the
separate_publishing
branch
from
21d86e1 to
70326f9
Compare
|
Thank you for the contribution! I plan to review this PR either tonight or tomorrow. |
lattera
requested changes
Dec 15, 2018
| rm -f ${tmpfile} | ||
| } | ||
|
|
||
| function do_sign() { |
There was a problem hiding this comment.
do_sign is probably not the best name for this function. update_dns_entry is likely better.
|
|
||
| ${TOPDIR}/updatedns.zsh ${apikey} hardenedbsd.org ${dnsentry} ${dnsstr} | ||
| sign=$(jq -r ".builds[${i}].sign" ${config}) | ||
| if [ "${sign}" != "null" ]; then |
There was a problem hiding this comment.
.builds[N].sign ought to be a called something more appropriate, perhaps updatedns. It should also be a boolean type, and checked as an optional boolean in code.
| local dnsentry apikey dnsstr | ||
| local config=$1 i=$2 dnsstr=$3 | ||
| dnsentry=$(jq -r ".builds[${i}].sign.dns" ${config}) | ||
| apikey=$(jq -r ".signing.apikey" ${config}) |
There was a problem hiding this comment.
Similar to above, the DNS integration isn't for signing.
|
Friendly ping. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow multiple publishers per build, separate the publishing
function into its own space, and add sftp/cp examples.
While there, make use of clean room builds in hbsd-update-build
and remove the assumption that all published builds must be signed
(here be dragons).