Update Remaining Code to SFML 3 & Update CI #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update checkout action to v4 - Add missing SFML dependency on Linux - Add new drawables - Update macOS image
eXpl0it3r
force-pushed
the
feature/update-ci
branch
from
b240c87 to
ca4b484
Compare
|
Thank you; I really appreciate the time you have spent to modify and update this code. It all looks fine to me. Looking through it, I've event noticed some stuff I'd not yet updated style-wise. Thanks again and welcome to the list of contributors :) |
|
🥳 Happy to see this merged! Thank you for these great tools and all the help your provide in the SFML community! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that CI was failing and wanted to fix it, but while doing so, I noticed that not everything has been updated to SFML 3 and all the examples were still on SFML 2, so I took the liberty to update them all.
You may want to check the examples a bit more closely, as I'm not familiar with them and might have messed something up.
There should also be potential in clean up some of the vector size/position usage.