[tests] Third-party performance test suite that runs Octane, JetStream, and Web Tooling Benchmark#358
Merged
Merged
Conversation
9efe825 to
649fbef
Compare
… and Web Tooling Benchmark
3fca528 to
b187d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a test harness for running brimstone with standard third-party JS performance test suites. Adds support for Octane, JetStream, and Web Tooling Benchmark.
Can run a full suite with
cargo run -p brimstone_perf -- --suite octaneor a particular benchmark withcargo run -p brimstone_perf -- --suite octane --bench richards. More details in the introducedREADME.Third-party tests suites are vendored under
tests/perf/vendorand are installed withtests/perf/install.sh. Note that for web tooling benchmark we generate a bundle for each individual benchmark so they can be run individually.Notes:
--flamegraphand passes flamegraph args with--flamegraph-arg=<arg>--expose-test-shell-compatargument--bin-path=<binary>argumentExample output (from a local run of Octane):
Tests
Verified that all of the following complete successfully:
cargo run -p brimstone_perf -- --suite octane, all benchmarks run successfullycargo run -p brimstone_perf -- --suite jetstream, some benchmarks fail due to missing APIs, WASM, etc but most runcargo run -p brimstone_perf -- --suite web-tooling, all benchmarks run successfullyAdded to CI job to verify that the performance test suite builds (though does not run it).