-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geo command for cylindrical billboarding #856
base: develop/2.4.0
Are you sure you want to change the base?
Conversation
Hell yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please repoint this to HackerSM64 2.4, since this isn't going to introduce any major conflicts (although it will conflict minorly with Lighting Engine).
fb3e34f
to
f895247
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming this was tested with newest changes and both with and without a DL.
would it perhaps be possible to make this a parameter for the command rather than a new ID? (can create a compatibility macro with one fewer param for existing repos / fast64) |
If the code isn't too different, I'd agree with this honestly |
Done, node pos/direction to camera version is gone now too, but easy to readd if needed |
looks better now but tbh i'm not totally sure how necessary axis is either |
The axis param is very helpful in cases where the axis you want to use isn't aligned to X, Y, or Z. For example, if someone adds a billboarded rope to their level, they can translate the node to one end of the rope, then set the axis to the relative position of the other end. If we force people to use a rotation node for this, they'll have to calculate the angle themselves. |
…ert to check axis when using it
Requested by Arctic