Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occlusion plane system #132

Merged
merged 18 commits into from
Jun 17, 2024
Merged

Occlusion plane system #132

merged 18 commits into from
Jun 17, 2024

Conversation

sauraen
Copy link
Collaborator

@sauraen sauraen commented Jun 6, 2024

This PR adds an occlusion plane management system, which is always enabled when F3DEX3 is enabled.

Occlusion plane candidates can be specified on a per-room basis, exported by fast64. This system runs once per frame, attempts to choose the best candidate from the available options using a bunch of heuristics, computes the F3DEX3 occlusion plane coefficients for that plane, and sends them to the RSP.

If in auto mode, it switches between base and NOC microcodes based on whether any occlusion plane candidates exist (effectively changes up to once per room transition). This also means that NOC will be used for vanilla scenes or for romhacks which don't use occlusion planes.

The system also uploads a modified version of the occlusion plane before the skybox is rendered, which is able to occlude sky triangles occluded by the scene. With this system and @Thar0 's changes to not clear the framebuffer before drawing the sky, the user must ensure that any occluding scene geometry is drawn with RA, not AA, rendermodes. If AA is used, graphical artifacts may occur along the edges of scene tris, as they will be drawing directly over an old framebuffer with possible partial coverage. The user must also ensure that the player cannot move the camera beyond the occluding scene geometry, or else the player will be able to see through the hole to past framebuffers, causing massive visual glitches. If these conditions cannot be met, the user should remove the code involving skyPlane in occlusionplanes.c.

@sauraen sauraen changed the title [WIP] Occlusion plane system Occlusion plane system Jun 11, 2024
@sauraen sauraen marked this pull request as ready for review June 11, 2024 05:51
src/code/occlusionplanes.c Outdated Show resolved Hide resolved
src/code/occlusionplanes.c Outdated Show resolved Hide resolved
@sauraen sauraen merged commit cda38b1 into develop/2.1.0 Jun 17, 2024
4 checks passed
@sauraen sauraen deleted the OcclusionPlanes branch June 17, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants