Reviewing CWV report V2 #38
Draft
+191
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- definitions/output/reports/cwv_tech_categories.js: Evaluated as low risk
Comments suppressed due to low confidence (1)
definitions/output/reports/cwv_tech_technologies.js:13
- Inconsistent naming of 'technology'. It should be consistently referred to as either 'tech.technology' or 'technology' throughout the file.
tech.technology
max-ostapenko
commented
Dec 23, 2024
| USING (category) | ||
| GROUP BY | ||
| category, | ||
| categories.origins | ||
| ORDER BY categories.origins DESC | ||
| description, |
There was a problem hiding this comment.
@sarahfossheim FYI v1/categories will get this additional field in January.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added category descriptions, using changes from Category descriptions wappalyzer#89
major numeric versions of technologies + "ALL" (no API)
lighthouse audit pass rates (no API)
performance opportunities (no API)
Aligning technology origins and adoption metric between the crux and the crawl data (category origins are using only crawl)
As discussed on the monthly call