upgraded IPP registrations to 2024-10-09 release #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=========================================
Coverage 85.17% 85.17%
Complexity 502 502
=========================================
Files 75 75
Lines 1916 1916
Branches 257 257
=========================================
Hits 1632 1632
Misses 158 158
Partials 126 126 ☔ View full report in Codecov by Sentry. |
HPNavjot
commented
Apr 11, 2025
| @@ -776,7 +780,7 @@ def fix_ktypes(type, syntax, name, group_name = ''): | |||
| intro = 'IntOrIntRangeType%s(' % set | |||
| type['ktype'] = 'IntOrIntRange' | |||
| type['kalt'] = [ 'Int', 'IntRange' ] | |||
| elif re.search('^integer(\([0-9MINAX: -]*\))?$', syntax): | |||
| elif re.search('^integer\s?(\([0-9MINAX: -]*\))?$', syntax): | |||
There was a problem hiding this comment.
\s will match whitespace, this is added to handle Integer(0:MAX) and Integer (0:MAX)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed #192