Skip to content

ci: add Action#5

Open
hyoklee wants to merge 53 commits into
HDFGroup:masterfrom
hyoklee:master
Open

ci: add Action#5
hyoklee wants to merge 53 commits into
HDFGroup:masterfrom
hyoklee:master

Conversation

@hyoklee
Copy link
Copy Markdown
Member

@hyoklee hyoklee commented Nov 13, 2022

This Action will demonstrate the following issues:

  • BUILD_EXAMPLES option is not working.
  • There is 1 test failure with BUILD_TESTING option.

@jhendersonHDF , please fix them until this Action passes.

Comment thread CMake/FindMOBJECT.cmake Outdated
PATHS /usr/local/include /usr/include)

find_library(MOBJECT_LIBRARY NAMES mobject-client
find_library(MOBJECT_LIBRARY NAMES mobject-bedrock
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs to be mobject-client rather than mobject-bedrock. mobject-bedrock doesn't really have any of the mobject symbols in it that the VOL would be looking for.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time, it did not work on Polaris. Since mobject changed a lot, I'll test again with client.

@jhendersonHDF
Copy link
Copy Markdown
Collaborator

Note that the main thing I noticed needed to be added was to set the environment variable

HDF5_RADOS_POOL=test_pool

It doesn't matter what you set it to, but it currently has to be set. Seems like this is a carryover from Ceph compatibility.

@hyoklee
Copy link
Copy Markdown
Member Author

hyoklee commented Nov 30, 2022

OK.

@hyoklee
Copy link
Copy Markdown
Member Author

hyoklee commented Nov 30, 2022

@jhendersonHDF
Copy link
Copy Markdown
Collaborator

@jhendersonHDF HDF5_RADOS_POOL doesn't help:

https://github.com/hyoklee/vol-rados/actions/runs/3586654622/jobs/6036110697

See https://github.com/mochi-hpc-experiments/mochi-tests/pull/62/files, please add -E -k to your IOR command line to skip the file deletion since the VOL currently doesn't support that.

@jhendersonHDF
Copy link
Copy Markdown
Collaborator

@hyoklee Is this PR finished now or is there more work to be done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants