Back button tooltip for Preview component #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiyushKashyapHCL
approved these changes
Dec 23, 2024
felix-hcl
requested changes
Jan 7, 2025
| @@ -91,6 +91,7 @@ export interface PreviewProps { | |||
| nextAsset: string; | |||
| previousAsset: string; | |||
| download: string; | |||
| backButton: string; | |||
There was a problem hiding this comment.
is this new property really required and not optional?
If so, this would lead to a breaking change. Currently the changelog only states a change and not a breaking change.
There was a problem hiding this comment.
Updated the changelog with the breaking change. Thanks
felix-hcl
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previewcomponent to take back button tooltip from TooltipTexts.