improved devices discovery when dealing with multiple NICs #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
first I want to thank you for this awesome lib, it is pretty nice :)
On my system I have multiple NICs, some of them are virtual, originally I thought I was facing the issue described here
#28
but later I realized that my case was a little different due to a VPN.
Even though this may not totally fix the issue, it certainly gives you a workaround and combined with business-specific code could help to totally avoid this situation.
For example, in my case I only want to scan the cameras on one specific network, but, if I wanted to scan more NICs I would combine this with code to scan the NICs and discard the virtuals.
Here is my current system NICs
Execution without the fix:
Execution without the workaround:
and the change is no disruptive
Regarding the bind_port, I also figured that the firewall may be preventing the socket to work properly and since it is randomly assigned it is hard to automate, by giving the option of setting it beforehand it gains automation points :)
just wanted to give you some ideas, thanks :)