Skip to content

Conversation

@Maxlego08
Copy link
Collaborator

Summary

  • replace player cache item lists with fastutil IntList identifiers and keep full items in global maps
  • index stored items by owner and add helper methods to resolve ids when rendering menus
  • add fastutil dependency to support lightweight id-based caching

Testing

  • not run (not requested)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +230 to +233
for (Item item : items.values()) {
if (item.isExpired()) {
this.auctionExpireService.processExpiredItem(item, storageType);
continue;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove expired items from storage when filtering

Expired listings are detected in getItemIds but the loop only calls processExpiredItem and never removes the expired entry from storageItemsById. Because the item stays in the LISTED bucket, every subsequent call that touches the cache re-runs the expiration side effects and the entry continues to be counted as listed (e.g., GlobalPlaceholders#listed_items reads getItems(StorageType.LISTED).size()). The previous iterator-based logic removed expired items, so this regression causes repeated expiration processing and inflated listing counts until a manual removal occurs.

Useful? React with 👍 / 👎.

@Maxlego08 Maxlego08 merged commit 6a654c8 into develop Jan 4, 2026
1 check passed
@Maxlego08 Maxlego08 deleted the codex/refactor-cache-system-to-reduce-ram-usage branch January 4, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants