-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.8.2 -- Fixed Tests #811
base: release-0.8.2
Are you sure you want to change the base?
Release 0.8.2 -- Fixed Tests #811
Conversation
…s2015 Map constructor warnings; Adding react-test-renderer
…er/shallow package; Replacing all references to react-addons-test-utils with react-dom/test-utils
…st-utils; Commenting out an unnecessary console.log
…mping up the minimum supported versions to 15.5.4
…n devDependencies to a version that supports react 16.x, and bumping react-test-renderer 16.x support back down to ^16.0.0
Tried a few things, but it seems like I can't update Not sure how to proceed with that, but at least it seems to work fine in Node 5+ |
FWIW, @ryanlanciaux @joellanciaux the Chartist demo on https://griddlegriddle.github.io/v0-docs/customization.html is broken:
|
Ahh - wonder if we should take that out. |
Nobody seems to have noticed, so it doesn't seem worth bending over backward to manage the extra dependency just for docs. 🤷♂️ |
Note: went ahead and made the react/react-dom 0.14.x and 15.4.x devDependencies changes discussed briefly in #809. I can easily revert that if anyone is uncomfortable with the idea, but then a discussion needs to be had around how to fix
react-addons-test-utils
issues.Griddle major version
0.8.2 (fixes targeted for this version release)
Changes proposed in this pull request
Why these changes are made
To get passing tests!
Are there tests?
No new tests; all existing tests pass (as of this branch)