Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ExtrapolatedRate calculation logic, introducing more robust error handling for input types and window layouts. It optimizes counter correction by incrementally updating values for contiguous windows and transitions to using Float64Builder for result construction. Additionally, the PR includes comprehensive unit tests covering various error scenarios and counter reset behaviors. Review feedback suggests marking the (false, true) match arm in func_name as unreachable to clarify that gauge rates are not supported by this specific function.
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
improve the performance by accessing the range array directly, removing unnecessary float op, and memoizing counter reset result etc.
benchmark result:
Details
PR Checklist
Please convert it to a draft if some of the following conditions are not met.