chore: add an initial internal sql-json-path query implementation#7620
Draft
sunng87 wants to merge 4 commits intoGreptimeTeam:mainfrom
Draft
chore: add an initial internal sql-json-path query implementation#7620sunng87 wants to merge 4 commits intoGreptimeTeam:mainfrom
sunng87 wants to merge 4 commits intoGreptimeTeam:mainfrom
Conversation
github-actions
bot
added
size/S
docs-not-required
Collaborator
MichaelScofield
left a comment
MichaelScofield
left a comment
There was a problem hiding this comment.
We have already used the jsonpath-rust for querying inside json data, why introduce another one?
| DataFusionError::Execution(format!("invalid jsonb binary: {e}")) | ||
| })?; | ||
| let mut json_str = jsonb_value.to_string(); | ||
| let json_value: simd_json::OwnedValue = unsafe { |
Collaborator
There was a problem hiding this comment.
Nit: best if we can unify the json string deserialization. Currently we have both serde_json and simd_json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch uses sql-json-path to implement an early version of sql-json-path query on our current json data. We will keep improve this for the upcoming json data structures.
The sql-json-path query language is from postgres. More information: https://github.com/obartunov/sqljsondoc/blob/master/jsonpath.md
See sqlness files in the changeset for some details.
I'm not going to include this in our docs until our new json data structure is available. And we will need more effort to port this on it.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.