Skip to content

Conversation

@shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR mainly does

  1. Add error attribute if status code is error for the jaeger UI
  2. Update query param to search both span attributes and resource attributes in v1

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@shuiyisong shuiyisong requested a review from sunng87 October 31, 2025 08:34
@shuiyisong shuiyisong requested a review from a team as a code owner October 31, 2025 08:34
@github-actions github-actions bot added size/S docs-not-required This change does not impact docs. labels Oct 31, 2025
@shuiyisong shuiyisong requested a review from evenyag October 31, 2025 08:36
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But can we add an integration test for it?

pub async fn test_jaeger_query_api(store_type: StorageType) {
@shuiyisong

@shuiyisong
Copy link
Contributor Author

LGTM

But can we add an integration test for it?

pub async fn test_jaeger_query_api(store_type: StorageType) {

@shuiyisong

Fixing the test right now

@sunng87 sunng87 added this pull request to the merge queue Nov 4, 2025
Merged via the queue into GreptimeTeam:main with commit 6caff50 Nov 4, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants