-
Notifications
You must be signed in to change notification settings - Fork 425
chore: improve search traces and jaeger resp #7166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But can we add an integration test for it?
greptimedb/tests-integration/tests/http.rs
Line 5380 in 6960a01
| pub async fn test_jaeger_query_api(store_type: StorageType) { |
Fixing the test right now |
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR mainly does
errorattribute if status code is error for the jaeger UIPR Checklist
Please convert it to a draft if some of the following conditions are not met.