fix: prom ql logical plan use column index not name #7109
Merged
+576
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
docs-not-required
|
It looks like there’s a lot of duplicated code and structs. Can we refactor them? |
discord9
force-pushed
the
fix/prom_ql_alias
branch
from
d4c5b50 to
1129482
Compare
refactor some method, but the "unfix" struct seems necessary, as refactor to either enum or use macro does seems even more messy, this is due to datafusion provided extension deserializer didn't provide input logical plan hence cause this issue |
discord9
force-pushed
the
fix/prom_ql_alias
branch
from
1129482 to
9612706
Compare
evenyag
reviewed
Oct 21, 2025
evenyag
approved these changes
Oct 22, 2025
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
discord9
force-pushed
the
fix/prom_ql_alias
branch
from
3fa2468 to
6a1271e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#7102
GreptimeTeam/greptime-proto#285 need merge first
What's changed and what's your intention?
to avoid substrait decode error, use index not name, which will prevent substrait from confuse column names since it will decoded to a slightly different plan(but project node's input schema should still in the same order)
This pull request contains AI slop
PR Checklist
Please convert it to a draft if some of the following conditions are not met.