Skip to content

ci: refactor bump downstream versions worflow and adds demo-scene #6171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented May 23, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR reactor the scripts to automatically trigger workflows in various repos based on version type, streamlining release processes and reducing manual effort.

Depends on GreptimeTeam/demo-scene#85

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@killme2008 killme2008 requested a review from a team as a code owner May 23, 2025 21:57
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 23, 2025
@killme2008 killme2008 requested review from nicecui and Copilot May 23, 2025 21:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the release workflow to simplify version bumping across multiple downstream repositories and integrates triggering for a new demo-scene.

  • Replaces the bump-doc-version job with bump-downstream-repo-versions.
  • Updates the working directory command and environment variables for the new job.
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:463

  • [nitpick] The TARGET_REPOS variable uses 'demo' while the PR title mentions 'demo-scene'. Consider aligning the naming for consistency.
TARGET_REPOS: website,docs,demo

@sunng87 sunng87 requested a review from daviderli614 May 28, 2025 22:52
env:
TARGET_REPOS: website,docs,demo
Copy link
Member

@daviderli614 daviderli614 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set Repository variables so that we can modify the repository list at any time later.

env:
  DOWNSTREAM_TARGET_REPOS: ${{ vars.DOWNSTREAM_TARGET_REPOS }}
key: DOWNSTREAM_TARGET_REPOS
value: website,docs,demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants