Skip to content

feat: add BuildIndexRequest to RegionRequestHeader #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

feat: add BuildIndexRequest to RegionRequestHeader #276

merged 2 commits into from
Oct 13, 2025

Conversation

@SNC123
Copy link
Contributor

@SNC123 SNC123 commented Sep 26, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As title.
Used for async index build in manual type.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@SNC123 SNC123 mentioned this pull request Sep 26, 2025
Merged
5 tasks
fengjiachun
fengjiachun approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc merged commit ee46a0e into GreptimeTeam:main Oct 13, 2025
7 checks passed
sunng87 added a commit that referenced this pull request Oct 14, 2025
@sunng87
Revert "feat: add BuildIndexRequest to RegionRequestHeader (#276)"
b27dd6c 
This reverts commit ee46a0e.
@sunng87 sunng87 mentioned this pull request Oct 14, 2025
Merged
2 tasks
@evenyag
Copy link
Contributor

evenyag commented Oct 15, 2025

We shall merge this after GreptimeTeam/greptimedb#7029 is approved.

MichaelScofield pushed a commit that referenced this pull request Oct 15, 2025
@sunng87
feat: add new json format (#281)
a250938 
* feat: add new json format

* refactor: rename native format

* chore: store nested data type in json_native_extension

* feat: use json as a concrete type in proto

* Revert "feat: add `BuildIndexRequest` to `RegionRequestHeader` (#276)"

This reverts commit ee46a0e.
sunng87 added a commit that referenced this pull request Oct 15, 2025
@sunng87
Reapply "feat: add BuildIndexRequest to RegionRequestHeader (#276)"
11076cf 
This reverts commit b27dd6c.
@sunng87 sunng87 mentioned this pull request Oct 15, 2025
Draft
2 tasks
@SNC123
Copy link
Contributor Author

SNC123 commented Oct 16, 2025

We shall merge this after GreptimeTeam/greptimedb#7029 is approved.

I've just created the corresponding upstream PR #7104, which should be merged after this one rather than #7029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@zhongzc zhongzc zhongzc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SNC123 @evenyag @fengjiachun @zhongzc