-
Notifications
You must be signed in to change notification settings - Fork 107
Fix typos and improve clarity in README and SECURITY documentation - … #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,18 +7,18 @@ To report a security issue, please email [email protected] | |
Our contributors are comprised of volunteers so we cannot guarantee a specific response time, but someone from our team will reply and address the issue as soon as possible. | ||
|
||
# Security Review | ||
We perform regular reviews inline with the information provided below. All releases go through these reviews but multiple people in the project team prior to release as part of our quality and security review. | ||
We perform regular reviews inline with the information provided below. All releases go through these reviews by multiple people in the project team prior to release as part of our quality and security review. | ||
|
||
## Basics | ||
### Basic Project Website Content | ||
- Describe what the project does - ✅ in README | ||
- Describe what the project does - ✅ in README | ||
- Provide info how to obtain/provide feedback and contribute - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/CONTRIBUTING.md#code-contribution-steps | ||
- Explain contribution process - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/CONTRIBUTING.md#collaborating-with-the-opensource-working-group | ||
|
||
### FLOSS license | ||
- Must be released as FLOSS - ✅ MIT License https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/LICENSE | ||
- Must post the license - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/LICENSE | ||
- Also approved by OSI - ✅ https://opensource.org/license/MIT/ | ||
- Also approved by OSI - ✅ https://opensource.org/license/MIT/ | ||
|
||
### Documentation | ||
- Provides basic documentation - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/tree/dev/docs | ||
|
@@ -27,16 +27,16 @@ We perform regular reviews inline with the information provided below. All rele | |
### Other | ||
- Project site, downloads etc must support HTTPS with TLS - ✅ using GitHub to host which supports this https://github.com/Green-Software-Foundation/carbon-aware-sdk/ | ||
- Have mechanism for discussion - ✅ github issues https://github.com/Green-Software-Foundation/carbon-aware-sdk/issues | ||
- Project must be maintained - ✅ actively maintaned by GSF and its members | ||
- Project must be maintained - ✅ actively maintained by GSF and its members | ||
|
||
## Change control | ||
### Public VCS repo | ||
### Public VCS repo | ||
- Readable public VCS repo - ✅ yes, Github https://github.com/Green-Software-Foundation/carbon-aware-sdk/ | ||
- Track changes - ✅ yes, Git https://github.com/Green-Software-Foundation/carbon-aware-sdk/commits/dev/ | ||
- Interim versions between releases available for review - ✅ yes, interim versions actively developed and availble on the `dev` branch https://github.com/Green-Software-Foundation/carbon-aware-sdk | ||
- Interim versions between releases available for review - ✅ yes, interim versions actively developed and available on the `dev` branch https://github.com/Green-Software-Foundation/carbon-aware-sdk | ||
|
||
### Unique versioning numbering | ||
- Unique indentifier for each release - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/releases | ||
- Unique identifier for each release - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/releases | ||
|
||
### Release notes | ||
- Human readable release notes for each release (not git log) - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/releases | ||
|
@@ -58,9 +58,9 @@ We perform regular reviews inline with the information provided below. All rele | |
- Must provide a working build system - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/docs/carbon-aware-cli.md#build-and-install https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/docs/containerization.md | ||
|
||
### Automated test suite | ||
- Have at least one automated test suite and documentation hwo to run it - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/.github/workflows/1-pr.yaml as automated CI during PRs | ||
- Have at least one automated test suite and documentation how to run it - ✅ https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/.github/workflows/1-pr.yaml as automated CI during PRs | ||
|
||
## New functionaility testing | ||
## New functionality testing | ||
- Formal/informal policy for adding tests for new features - ✅ PR template requires stating if a breaking feature added, maintainers ensure tests are in place: https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/dev/.github/pull_request_template.md | ||
- Evidence of policy being adhered to - ✅ on release code coverage increase (new code added did not decrease test coverage): https://github.com/Green-Software-Foundation/carbon-aware-sdk/pull/437#issuecomment-1862346606 | ||
|
||
|
@@ -79,17 +79,17 @@ We perform regular reviews inline with the information provided below. All rele | |
- https://www.bestpractices.dev/en/criteria/0#0.crypto_keylength - ✅ uses dotnet 8.0 implementations | ||
- https://www.bestpractices.dev/en/criteria/0#0.crypto_working - ✅ uses dotnet 8.0 implementations | ||
- https://www.bestpractices.dev/en/criteria/0#0.crypto_password_storage - ✅ ⚠️ uses dotnet 8.0 implementations | ||
- https://www.bestpractices.dev/en/criteria/0#0.crypto_random - ✅ uses dotnet 8.0 implementatons for HTTPS | ||
- https://www.bestpractices.dev/en/criteria/0#0.crypto_random - ✅ uses dotnet 8.0 implementations for HTTPS | ||
|
||
### Secured delivery against man-in-the-middle (MITM) attacks | ||
- Delivery mechanisms that counters MITM - ✅ uses HTTPS | ||
- Cyrptographic hash NOT retrived over HTTP - ✅ ues HTTPS | ||
- Cryptographic hash NOT retrieved over HTTP - ✅ uses HTTPS | ||
|
||
### Publicly known vulnerabilities fixed | ||
- No unpatched vulnerabilities of medium or higher severity that have been publicly known for more than 60 day - ✅ no such vulnerabilities | ||
- No unpatched vulnerabilities of medium or higher severity that have been publicly known for more than 60 days - ✅ no such vulnerabilities | ||
|
||
### Other security issues | ||
- Public repo doesnt leak private credential - ✅ does not do that | ||
- Public repo doesn't leak private credential - ✅ does not do that | ||
danuw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
## Analysis | ||
### Static code analysis | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.