-
-
Notifications
You must be signed in to change notification settings - Fork 579
Fixes method for appending bezpath to the 'VectorData' and the 'Scatter Points' node implementation. #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b933beb
to
c4d8f63
Compare
Though refactoring 'Scatter Points' node changed look of the 'Red Dress' demo artwork. @Keavon |
That's unfortunate. It seems to have affected all the Red Dress scatter points layers, not just the one (which I assumed was due to numerical instability). This leads me to believe something may be being altered more fundamentally which you could avoid by debugging the PR's changes and finding what part of the logic has resulted in a different result. |
I tried debugging but could not understand why it really changes that much. I will try to find the cause again but It would be helpful if you give a quick look to the changes and maybe point out the lines which could be causing this. NOTE: I've not made any chages to the possion_disk_sample() algorithm it self but the only to checking the insideness of a point to the bezpaths. |
Just from my quick glance, some of the changes in |
I tried to do the point insidness checking as it was done before using kurbo and only fixing the bug in the 'Interactive Snake Pebbles', which was due to incorrect insidness checking with bounding boxes, but yet the behaviour was same to the current behaviour. I will give it another try and see why this happens. Thanks. |
Fixes mistakes I made in 'append_bezpath()' method #2608 and 'Scatter Points' #2634 node refactoring.