Skip to content

Comments

Add input hints to interactions in the node graph#2415

Merged
Keavon merged 7 commits intoGraphiteEditor:masterfrom
Sidharth-Singh10:node_graph
Apr 9, 2025
Merged

Add input hints to interactions in the node graph#2415
Keavon merged 7 commits intoGraphiteEditor:masterfrom
Sidharth-Singh10:node_graph

Conversation

@Sidharth-Singh10
Copy link
Contributor

Closes #1820

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review March 9, 2025 23:30
@Keavon Keavon marked this pull request as draft March 13, 2025 00:59
@Keavon
Copy link
Member

Keavon commented Mar 13, 2025

Your approach only makes it show the hints momentarily, once, when the graph is opened. It needs to take control during that mode (and allow for supporting additional in-progress interactions).

@Sidharth-Singh10
Copy link
Contributor Author

Sidharth-Singh10 commented Mar 13, 2025

@Keavon I moved update_node_graph_hints from DocumentMessageHandler to NodeGraphMessageHandler and implemented showing different hints based on current actions (dragging, wire connection, node selection)

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review March 13, 2025 17:59
@Keavon
Copy link
Member

Keavon commented Mar 17, 2025

!build

@github-actions
Copy link

📦 Build Complete for a97e406
https://7ca4b2a1.graphite.pages.dev

@0HyperCube
Copy link
Contributor

@Sidharth-Singh10 Thanks for your work so far. However when I pan the node graph (drag with the middle mouse button), the hints for the tool are shown again.

tool_hints_on_pan.mp4

To fix, you will need to modify the tool_message_handler.rs file, specifically references to ToolMessage::UpdateHints.

@0HyperCube 0HyperCube marked this pull request as draft March 26, 2025 18:52
@Sidharth-Singh10
Copy link
Contributor Author

@0HyperCube
The bug is fixed now

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review March 26, 2025 20:21
@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@Keavon Keavon changed the title Add hints in status bar when node_graph overlay is displayed Add input hints to interactions in the node graph Apr 9, 2025
@Keavon Keavon enabled auto-merge (squash) April 9, 2025 05:35
@Keavon
Copy link
Member

Keavon commented Apr 9, 2025

Please leave a comment in the issue.

@Keavon Keavon merged commit b38d725 into GraphiteEditor:master Apr 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hints in the node graph

3 participants