V1.2 documentation plus a few bug fixes #334
Conversation
documentation for v1.2
DrTimothyAldenDavis
requested review from
michelp,
jim22k,
swilly22 and
mcmillan03
|
In my recently merged PR for the upcoming v1.2 release, I neglected to update the documentation rtdocs. This PR adds documention for the two new utility funtions, LAGraph_Random_Seed and LAGraph_Random_Next. I also updated the acknowledgments file and the copyright date. |
revise CI badge URL
bug fix in FastAssign, and bug found in SwapEdges (not yet fixed)
|
Don't merge this yet ... I found a bug but haven't fixed it yet. |
SwapEdges: recompute n_keep, and return num_swaps
DrTimothyAldenDavis
changed the title
|
I fixed the bugs but I'm waiting to check with @GomezGab about my bug fixes to SwapEdges, FastAssign, and RCC. I also need to post a formal release of GraphBLAS 10.1.0 and update the workflow yaml files here so LAGraph is tested against that version (as well as the older 9.0.0). Otherwise, I think this PR is good to go, and I think it's ready to become LAGraph v1.2. Once this PR is merged, I'll post a beta v1.2 release, to get wider feedback. |
| @@ -191,7 +191,7 @@ int LAGraph_FastAssign_Semiring | |||
| GRB_TRY (GrB_Vector_size(&nrows, c)) ; | |||
| } | |||
|
|
|||
| GRB_TRY (GrB_Vector_get_INT32(X_vec, (int32_t *) &iso, GxB_ISO)) ; | |||
| GRB_TRY (GrB_Vector_get_INT32(X_vec, &iso, GxB_ISO)) ; | |||
There was a problem hiding this comment.
I don't use iso or x_type in this function anymore. So these calls and variables should be deleted.
There was a problem hiding this comment.
That's what I thought but I left it in case you needed it for something else in the future. Deleting it is better.
Remove unneeded FA code and modified SE test
V1.2: cleanup for FastAssign, test for SwapEdges
github CI: test with GraphBLAS 9.0.0 and 10.1.0
github CI: use dev2 branch of GraphBLAS for dispatch-only arch-emu tests
Adding documentation for the new LAGraph_Random_Seed and LAGraph_Random_Next methods, for LAGraph v1.2.0.