Enhance docs about reproducible builds #1882
Merged
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
Dec 5, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the reproducible builds documentation by adding comprehensive information about file permissions handling. The documentation now explains that reproducible builds configuration not only controls file timestamps and ordering but also normalizes file permissions regardless of local umask settings, which is crucial for achieving byte-for-byte identical builds across different environments.
Key changes:
- Added explanation about file permissions and umask handling in reproducible builds
- Included code examples for setting POSIX file permissions (755 for executables/directories, 644 for regular files)
- Added reference link to reproducible-builds.org for additional context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Goooler
reviewed
Dec 5, 2025
| Besides file timestamps and file order, this configuration also ensures that all files in the JAR are set to have the | ||
| same permissions, irrespective of the locally configured umask. | ||
|
|
||
| More information about reproducible builds can be found at [reproducible-builds.org](https://reproducible-builds.org/). |
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1848.