-
-
Notifications
You must be signed in to change notification settings - Fork 424
Support disabling Kotlin module metadata remapping #1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -43,6 +43,7 @@ public open class ShadowCopyAction( | |||||||||||
| private val transformers: Set<ResourceTransformer>, | ||||||||||||
| private val relocators: Set<Relocator>, | ||||||||||||
| private val unusedClasses: Set<String>, | ||||||||||||
| private val enableKotlinModuleRelocation: Boolean, | ||||||||||||
| private val preserveFileTimestamps: Boolean, | ||||||||||||
| private val failOnDuplicateEntries: Boolean, | ||||||||||||
| private val encoding: String?, | ||||||||||||
|
|
@@ -174,7 +175,7 @@ public open class ShadowCopyAction( | |||||||||||
| } | ||||||||||||
| } | ||||||||||||
| path.endsWith(".kotlin_module") -> { | ||||||||||||
| if (relocators.isEmpty()) { | ||||||||||||
| if (relocators.isEmpty() || !enableKotlinModuleRelocation) { | ||||||||||||
| fileDetails.writeToZip(path) | ||||||||||||
| } else { | ||||||||||||
|
Comment on lines
176
to
179
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to expose the transform step for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I see - the current change just disables remapping, but still does not trigger generic transformer. It would be nice to add a support for custom
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a new issue: if the shadow/src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt Lines 183 to 187 in bd7f137
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Disabling the newly added flag should align the behaviors with 8.x versions. Are you fine with the new flag? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, should be fine |
||||||||||||
| fileDetails.remapKotlinModule() | ||||||||||||
|
|
||||||||||||
Uh oh!
There was an error while loading. Please reload this page.