feat: move centralPortal {...} to publishing {...} #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
cp_options
branch
2 times, most recently
from
e80a48a to
483ba4d
Compare
It sounds reasonable to have Central Portal settings under `publishing {..}`,
and it sounds reasonable to have the same configuration API for both
aggregating and non-aggregating nmcp
Member
|
Thanks for the proposal. I understand the concern but I'd rather not tie us too much to |
Contributor
Author
|
ok, it would be nice to deduplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds reasonable to have Central Portal settings under
publishing {..}It sounds reasonable to have the same configuration API for both aggregating and non-aggregating nmcp.